Zoom becomes non-integer after pinch-zoom on Android's webkit - v0.7

[kaansoral]

This doesn't always happen, however it does happen easily

The zoom becomes a floating point number like 7.871... and the tiles stop showing, I bet because the images are requested with floating point zoom too

It is a retina device, if it changes anything, android 4.3, webkit component

This didn't happen on v0.5.1

[mourner]

Oh, not again... @danzel any ideas?

[danzel]

What is on your map @kaansoral ?
We did (do?) have a bug where having other animated things on your map could prematurely end a zoom.

Could you please make a minimal reproducable map and I'll try take a fiddle. Thanks.

[kaansoral]

There are mapbox tiles with wax connector, and L.marker's

Since there were previous issues with size detection on mobile (causing un-rendered sections in visible areas - probably android's fault somehow - again) I did create several manual map.invalidateSize triggers, after reading your comment, I realized maybe they could be causing the zoom issue if they are called in-between zoom animations?

I will try create a minimal reproducable map - if it isn't the map.invalidateSize

[danzel]

That could be it, have a fiddle and find out :)

[mourner]

Related issue: #1934

[mourner]

@kaansoral any updates?

[kaansoral]

Haven't got a chance to test it in-depth yet

I could prioritize it if it's crucial to the development, if so, should I test for anything specific?

Initially, calling map.setZoom + map.invalidateSize(false), or vice versa, didn't produce the issue, I've also tested adding a delay

[mourner]

Can you reproduce the issue in a minimal JSFiddle test case?

[kaansoral]

Since this is happening inside Phonegap / on the webkit component, it would take some time to do it

In the meantime, I will try to pinpoint exactly what's causing it, and maybe try to reproduce it on iOS's webkit too

[danzel]

I can reproduce this on ie 10/11 touch by randomly spamming my fingers on the screen.
Will try see if I can work out what is causing it there, might be the same.

[danzel]

I'm gonna dump a bit in here as I debug this. will edit this comment so you all don't get updates :)

In Map.js before this._zoom = zoom; I compare zoom to check if it is an int, if not debugger;

        if (zoom != (zoom | 0)) {
            debugger;
        }

The same code is in getZoom in case there is something I miss.

I randomly smash the map around, eventually this happens:
Map.ZoomAnimation _catchTransitionEnd is triggered.
_animatingZoom is true, so we go in to _onZoomTransitionEnd, but _animateToZoom is not an integer value.

Lol, the transitionEnd is for opacity. got it :)
todo: event.propertyName