openPopup method for paths (polygons, polylines, circles)

[mourner]

[cole-gillespie]

Currently you have a Path.popup.js file. Polygons, polylines and cirlces all extend Path.

For this feature request would you remove Path.popup.js and just move the right popup methods to the respective "Parent.Popup.js" ( Polygon.Popup.js , Polyline.Popup.js , Circle.Popup.js )?

In other words you want to have a separate Popup.js file for each Polygon, Polyline and Circles file.

something like

L."Parent".include({ /*.. popup logic ..*/ });

[mourner]

Maybe. In theory, different classes have different representation point from which to open the popup and correspondingly different algorithms for calculating such point, so I'd have to split that logic into a separate file for each class I guess.

[cole-gillespie]

would you be willing to review code if i wrote it for this ticket?

[mourner]

Sorry for not answering, I somehow missed this comment... I would sure take a look at your code if you wrote it.

[mourner]

Done in 0e4e02a