Events inside popup don't propagate outside the map

[jones139]

I am trying to create a popup on a marker, which contains buttons, but I am having trouble with events not firing from the buttons on the marker popup.

I create the popup with
function addMarker(e) {
var marker = new L.Marker(e.data.latlng,{clickable:true, draggable:true});
map.addLayer(marker);
var content = "Marker " +
"Delete Marker" +
"Cancel";
marker.bindPopup(content);
marker.on('dragend',onMarkerDragEnd);
map.closePopup(popup);
}

And try to catch the event from the button with:
jQuery('#deleteMarker').live('click',function(e) { alert('delete'); });

Similar code that just adds a popup to the map works, but the above does not when the popup is bound to a marker.

I have tried modifying Popup.js to remove the disableClickPropagation command (line 81 - https://github.com/jones139/Leaflet/commit/117db3515c6b8070e0d2c42ff4bc1030fe5feef4), and this gets my events working, but the clicks also propagate down to the map. Therefore I think it is an issue in Leaflet somewhere?.....Or I may be doing it wrong!

[mourner]

Stopping propagation to the map inside popup is intended by design, and jQuery "live" depens on propagation to the document. So I'd suggest not using jQuery live function in this case. The best practice for buttons inside popups is to create the buttons dynamically as DOM objects (using document.createElement, document.appendChild, etc.) and then pass a DOM object instead of HTML string to the bindPopup method.

[jones139]

Thanks - I'll try that!

[krosaen]

Hi, i would love to see the option to not disable propagation from clicks on popups. Attaching handlers to every single popup is much less efficient than having a delegate or live handler covering all at once, and it is harder to avoid resource leaks too.

I have a custom TileLayer that places dom elements within the tiles, and the events propagate from there, and it seems to work just fine; I don't see why it would be harmful or undesirable for events to propagate from popups either. Any clarification as to why stopping propagation is intended by design?

[krosaen]

Ok, after playing with this and adding the option to let events propagate I can see why this is necessary now: otherwise any click within the popup propagates to the map, which closes the popup (a general feature of leaflet - clicking on the map will close any open popups). Some more work would be necessary to allow this to work as a viable option for delegate handlers. I know it works in google maps, so seems like a reasonable feature. Perhaps some way of marking the event so the map knows to not close the popup.

[rickhall]

Are there any more thoughts on this? I agree with the comments in issue 765, it seems like it should be possible to modify the map click handler to detect if a click originated in a marker/popup and just ignore that case.

I am using the Leaflet clusterer with tens of thousands of markers and it seems like event delegation would make a lot of sense here so I could avoid creating thousands of event listeners. I would like to be able to bind one listener to receive any click on a marker and then dynamically create a popup on the marker to also avoid creating thousands of popup.

This seems like a reasonably small improvement that could be very helpful for resource/performance concerns.

[rickhall]

Just a followup on myself, it appears that the Leaflet clusterer plugin allows me to register a single event listener on a cluster or markers, so I guess that works ok for what I want to do. However, I think it still makes sense to make this possible in general.

[danzel]

The reason this works in L.MarkerCluster is that it is a L.FeatureGroup, which you can set event listeners on and it will set them on all of its child markers.

[rickhall]

Bummer if it isn't doing it in a more efficient way that just adding the event listener to all thousands of the markers... Thanks for the comment.

[mourner]

OK, done as suggested by @krosaen & @rickhall (marking click events as ignored by map) — seems to work, yay! Guys, could you please try that out and tell if it works well for you?