Marker click event stops firing if the marker is ever moved by dragging

[mehmeta]

In src/layer/marker/Marker.js line 134:

As stated in the title, if you create a marker, add a click handler, enable dragging. drag the marker and disable dragging, you're effectively preventing the marker 'click' event from ever firing again. Genuinely curious, why is this necessary? The workaround is setting _moved to false:

but it's obviously hackish.

[aceiii]

Tested it out and it occurs when the marker is moved and then disabled before it is clicked again. If the marker is clicked before the dragging is disabled, the click events will still fire. This issue also affects the Map because it's _onMouseClick function also does the same check.

The check is there to prevent false click events from being fired when the mouse is released after the element is dragged. A somewhat suitable fix would be to set this._moved = false; in the disable method in L.Draggable. There is an edge case where the issue will still occur if for some reason dragging is disabled while the user is currently dragging.

[mehmeta]

This is very helpful, thank you. Considering dragging for a marker would typically get enabled or disabled in response to an action within the UI that's not the dragging action itself, I think having that issue with the edge case you described is more acceptable than having a valid set of actions (enable dragging, drag marker, disable dragging) causing the marker to lose its ability to fire click handlers completely... So is it possible to go ahead with the fix?

[mourner]

@aceiii, thanks for answering, you're completely right, and I agree with the mentioned fix. Regarding the case with disabling dragging while dragging — a suitable fix would be to force onUp on disable if dragging is in progress.