Added event for when loading image fails + documentation #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event and existing error handling. Also added missing documentation for the load event.
|
This is the same as PR #5415 without the extra documentation file. |
perliedman
approved these changes
Mar 28, 2017
| describe('when loaded', function () { | ||
| it('should raise the load event', function () { | ||
| var loadraised = false; | ||
| overlay.once('load', function () { loadraised = true; }); |
There was a problem hiding this comment.
While this works, you can also use sinon to do this and similar tasks in a more explicit fashion, see for example https://github.com/Leaflet/Leaflet/blob/master/spec/suites/core/EventsSpec.js#L20
| describe('when load fails', function () { | ||
| it('should raise the error event', function () { | ||
| var errorRaised = false; | ||
| overlay.once('error', function () { errorRaised = true; }); |
There was a problem hiding this comment.
...same here, sinon would be great.
There was a problem hiding this comment.
So basically the same as jasmine as you can do jasmine.spy.
Will bear that in mind for any future contributions :)
This was referenced Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added event for when loading image fails on ImageOverlay layer and added missing documentation for load event