Mouse Events on Vector Overlays don't propagate to map

[mlevans]

Hi,

I have some vector overlays on a Leaflet map and have had trouble getting mouse events to propagate to the map; I just want to drag the map when I'm over a vector layer.

I ended up commenting out the following line: https://github.com/CloudMade/Leaflet/blob/master/dist/leaflet-src.js#L3734, which fixed the problem. I'm just not sure if it's a reasonable solution (or the possible ramifications of commenting out this line). Have you seen this problem before? Does this seem like an acceptable solution?

Thank you!

[mourner]

You're right, it wasn't like this in the stable version... I'll take a look. Thanks for the report, seems quite critical!

[mourner]

Fixed, thanks! It only reproduced when polygon had a mousedown listener (and it always has it in GeoJSON layer for propagating events).

[mlevans]

Awesome! Thank you!

[trey-jones]

Hi, I'm not sure whether it's proper to post on a two month old issue, but this doesn't seem to be fixed at all. Click events still don't propagate through SVG layers (GeoJSON in my case). Perhaps I've misunderstood the problem and the solution.

The issue is this line:
https://github.com/CloudMade/Leaflet/blob/master/dist/leaflet-src.js#L3848

But like mievans, I'm not sure what impact this has on something else. Can we just pass the event on:
this._map.fire('click', e);

I'll be doing something like that in my implementation, but I thought I'd comment here, just to see if this is intended behavior, and to see if it's an issue unique to me.

[danzel]

Thanks @trey-jones
Removing the stopPropogation might be the way. Although if you do then popups on the polygon don't work, which is no good! Will do a bit more investigation.

[danzel]

Click events on markers also don't propagate down.

I've sent PR #1033 to change this behaviour so that if no one is listening to click events on the Marker/Path then it will propagate down to the map.
For example if you bind a popup then the click event won't propagate down to the map.

Give this a test please @trey-jones and see if it works for your usages.
@mourner please review and if it needs any improvement or if I've missed something I'm happy to fix up as always :-)

[trey-jones]

I actually tested this (only with L.GeoJSON), and this.hasEventListeners('click') returns true, so it doesn't have the desired effect. What that listener is and where it comes from is not immediately obvious. I don't believe that it's something I've added.

[danzel]

Ah drat. Yeah, L.GeoJSON is a FeatureGroup, so it sets up listeners on all of its children by default.
Try find/replace FeatureGroup -> LayerGroup in layer/GeoJSON as well as that patch above and see what happens, I think that'll make it work.
Not sure on a proper fix if that works though, will have a think.