onselectstart not implemented

[lookfirst]

Thanks for a really nice library.

I get automated error messages emailed to me via an onError handler and noticed this one:

  "message" : "Not implemented\r\n",
  "script" : "/js/leaflet/leaflet-src.js",
  "linenumber" : 716,
  "userAgent" : "Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB7.3; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; BRI/2; .NET4.0C; .NET4.0E; IPH 1.1.21.4019)"

Failing on this...

    enableTextSelection: function () {
716:        document.onselectstart = this._onselectstart;
        this._onselectstart = null;
    },

Using 0.4.4.

[bryguy]

I am also getting this same error in IE7 when clicking on the zoom controls. It would appear that _onselectstart is undefined. My workaround was to simply wrap the existing function body in a conditional checking for a truthy value of this._onselectstart, like so:

enableTextSelection: function () {
    if (this._onselectstart) {
        document.onselectstart = this._onselectstart;
        this._onselectstart = null;
    }
}

[lookfirst]

closing this issue now that there is a pull request at #893

[vitch]

I've had this same problem with my app in IE8 and have implemented this fix. Just wanted to make sure it hadn't been lost since I'm using 0.4.5 and this fix isn't in there...

[lookfirst]

@vitch you're right. it seems there is no longer a check for this._onselectstart... the code looks like this in master right now...

enableTextSelection: function () {
        if (document.onselectstart === L.Util.falseFn) {
            document.onselectstart = this._onselectstart;
            this._onselectstart = null;
        }
    },

@mourner ????

[mourner]

Hmm, I don't know how it got out but I'll add it back, thanks. :)