WMS layer always appends ? even if WMS server address already contains query string params

[StupidTook]

We are using in-house developed WMS server that takes additional params that are not part of WMS protocol.

It looks like this:

var layer = L.tileLayer.wms("http://example.com/Wms.aspx?map=1", {
    layers: 'buildings',
    format: 'image/png',
    transparent: false    
});

The problem is, leaflet appends WMS params with ? prefix regardless of whether the url already has params or not, so what we get is:

http://example.com/Wms.aspx?map=1?service=WMS&request=GetMap

It would be really nice if leaflet could append its params using ampersand if the service address already includes a query string.

[mourner]

Oops, confirmed, will be fixed.

[drnextgis]

I guess it is not bug, you should use your vendor-specific params within WMS layer options params alongside layers, format etc. in your case.

[mourner]

@drnextgis problem is that Leaflet disregards vendor-specific params at the moment.

[snkashis]

@mourner, shall we close this since my PR is now in? Then we are below 20 issues for 0.5 milestone..

[mourner]

Yep!