Skip to content

Conversation

fdlk
Copy link
Contributor

@fdlk fdlk commented Sep 23, 2012

This fixes #1012

@northlandiguana
Copy link

Add the following to L.Path._updateStyle:

if (this.options.radius) {
this._radius = this.options.radius;
};

I'm new to GitHub, so I don't know how to do this to the source code on here myself.

@fdlk
Copy link
Contributor Author

fdlk commented Oct 6, 2012

Hi northlandiguana, this issue is a pull request containing a fix for it.
In the Files Changed bit you can see what I made of it.
A Path does not have a radius and therefore its code should be kept clean of all things radius.
This needs fixing in CircleMarker, I think.

I took another look at the code and a CircleMarker always has a radius option so the check is superfluous there.

@northlandiguana
Copy link

I see where the file update is now. Sorry for being a GitHub virgin :-). Thanks.

@ghost ghost assigned mourner Oct 12, 2012
mourner added a commit that referenced this pull request Jan 11, 2013
radius is part of CircleMarker style so should be changeable in using setStyle();
@mourner mourner merged commit 116671f into Leaflet:master Jan 11, 2013
@mourner
Copy link
Member

mourner commented Jan 11, 2013

Finally got to this, sorry for such a delay and thanks for the pull!

@fdlk
Copy link
Contributor Author

fdlk commented Jan 11, 2013

My pleasure and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleMarker.setStyle() does not respect changes in radius
3 participants