can't add scale control to uninitialized map

[jfirebaugh]

This throws an error:

var map = L.map('map');
L.control.scale().addTo(map);​

http://jsfiddle.net/CtJu7/1/

Can we special-case map.on('load', callback) to work like jQuery load, triggering the callback immediately if the map has already been loaded? Then Scale#onAdd could do:

map.on(options.updateWhenIdle ? 'moveend' : 'move', this._update, this);
map.on('load', this_update, this);

And this code could be refactored.

I'll send a PR if you agree.

[mourner]

Sounds useful, although I don't like having two different behaviors in one interface depending on some hardcoded event types. Need to think this through.

[mourner]

At the moment I think I'll just add map._loaded check in the Scale control and will refactor in future.

[jfirebaugh]

I turned this into a PR that shows how this can be done pretty cleanly. See what you think.

[mourner]

Did you change this to avoid calling splitWords every time?

[jfirebaugh]

See this commit message for the rationale for those changes.

[mourner]

I see now. Still don't quite like the addEventListener overloading approach — it's quite confusing, as you normally wouldn't expect the listener to be immediately called when attached — this detail is hidden in implementation. E.g. if you call $(document).bind('ready', ...), the listener won't be called if DOMReady already happened, unlike explicit ready method.

How about adding a special method for map instead of overloading addEventListener? I mean, something like:

map.whenReady(this._update);

It would be simpler both in API and implementation.

[jfirebaugh]

That's a good point -- I'll implement what you suggested.

[mourner]

Please revert the alias changes then. I'm a perfectionist, what can be written shorter and simpler should be done so. :)

[jfirebaugh]

Done.

[mourner]

Looks good!