need a baselayerchange event #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Converted to pull request. |
|
Nice idea with testing! Merging, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting when the base layer has changed (e.g. from clicking in a
Layerscontrol) is harder than it should be.The Layers control does not define the order in which it adds and removes layers, so input that changes the base layer may result in a
layeraddevent followed by alayerremoveevent, or alayerremoveevent followed by alayeraddevent. This means that any handlers that are bound to either or both events cannot assume that the map has exactly one base layer. It may have zero, one or two depending on the order of events.I suggest that the
Layerscontrol trigger abaselayerchangeevent on the map after responding to input that changes the base layer. This event would be triggered after the other layer events, and it would include alayerproperty set to the resulting base layer.