IE10 touch support #1076
Merged
IE10 touch support #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DomEvent.DoubleTap). DoubleTap touch on IE10 doesn't currently work but everything else does. Refs Leaflet#871
… count manually and clone the object so we can change the type.
…sues. Also fixes removeDoubleTapListener for all platforms
…them (cherry picked from commit ec2989e)
…ERANCE (cherry picked from commit b7e84ae)
…fter the drag has finished (clicking during a drag seems weird).
…g off screen bug without needing the work around
…document so that we get all of them, otherwise we will miss some and mess up our touch coun tracking.
…t and never let go otherwise we can miss MSPointerUp events.
…(which it of course isn't!)
| 'core/Handler.js', | ||
| 'map/handler/Map.TouchZoom.js'], | ||
| deps: ['MapAnimationZoom'], | ||
| desc: 'Enables smooth touch zooming on iOS and double tap on iOS/Android.' | ||
| desc: 'Enables smooth touch zooming on iOS and IE10 and double tap on iOS/IE10/Android.' |
There was a problem hiding this comment.
Btw, smooth zoom is now on Android 4 too, right?
There was a problem hiding this comment.
Multi-touch zoom is on android 4 yeah, we added it in 0.4:
https://github.com/CloudMade/Leaflet/blob/master/CHANGELOG.md#notable-new-features
This can indeed be tidied up! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @oliverheilig and @veproza for testing and helping.
Fixes #871.
Hopefully doesn't break too many things ;-)