GeoJSON GeometryCollection passes consisent params to pointToLayer #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah forgive my earlier naivete there is really no way that that commit would pass lint but the code is I believe the fix to #1082 which I can resubmit if it looks like the right thing |
|
I just didn't yet look at it closely... Let's keep it open for reference, I'll get back to it a bit later. |
|
I stand corrected it does pass lint, I was just looking through my old open requests and removing ones that look like I had made them in haste. |
|
@calvinmetcalf please fix the whitespace and also remove the quotes in object keys. |
|
like this? |
|
Looks good! |
mourner
added a commit
that referenced
this pull request
Jan 14, 2013
GeoJSON GeometryCollection passes consisent params to pointToLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code that deals with this issue so that pointToLayer passes consistent parameters when it's called on GeometryCollections.