Skip to content

Added 'layeradd' and 'layerremove' events to LayerGroup. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2012
Merged

Added 'layeradd' and 'layerremove' events to LayerGroup. #1122

merged 1 commit into from
Nov 6, 2012

Conversation

jacobtoye
Copy link
Member

Handy when wanting to know when layers are added/removed to a specific LayerGroup rather than the map.

mourner added a commit that referenced this pull request Nov 6, 2012
@mourner
Merge pull request #1122 from jacobtoye/LayerGroupEvents
85ed215 
Added 'layeradd' and 'layerremove' events to LayerGroup.
@mourner mourner merged commit 85ed215 into Leaflet:master Nov 6, 2012
@stsydow
Copy link
Contributor

stsydow commented Nov 7, 2012

This breaks the LayerGroup class - fire() is undefined.

layer = new L.LayerGroup();
map.addLayer(layer);
layer.addLayer(new L.Marker(...));

I assume LayerGroup should inherit it from somewhere.
Am I just doing it wrong?

@mourner
Copy link
Member

mourner commented Nov 7, 2012

Oops, should be moved to FeatureGroup. One moment. @jacobtoye please update to FeatureGroup

mourner added a commit that referenced this pull request Nov 7, 2012
@mourner
fix typos and regression in #1122
7517cbc
@jacobtoye
Copy link
Member Author

Ah what a rookie :( Sorry guys.

emartinez-usgs pushed a commit to emartinez-usgs/Leaflet that referenced this pull request Feb 27, 2013
@mourner @emartinez-usgs
fix typos and regression in Leaflet#1122
37f854a
emartinez-usgs pushed a commit to emartinez-usgs/Leaflet that referenced this pull request Aug 15, 2013
@mourner @emartinez-usgs
fix typos and regression in Leaflet#1122
cab78bb
@alekzvik alekzvik mentioned this pull request May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtoye @stsydow @mourner