Add retina marker icon support and retina-ize the default icon

[danzel]

Fixes #1048
Will do documentation updates in a moment...

[mourner]

I think the old icon looks a bit better... More balanced and "rounded". Take a look at the swipe view... Try adjusting the source a bit.

Also, maybe it would be better to put the source svg somewhere else, I don't like introducing a new top level folder for only one file. Maybe src/img? Or layer/marker?

And what do you think about the shadow image? Does it need a 2x equivalent?

[danzel]

Yeah have been fiddling with the image to try make it a closer match, its not easy :)
Will fiddle more later today.

src/img is probably okay for the file, putting it in with the code is a bit messy. Will move.

I don't think the shadow needs a 2x equivalent, I don't notice the shadow being low res as it is.

[mourner]

So Dave, any progress? :)

[danzel]

Will spend some more time on this today hopefully!

[danzel]

Okay, made it look better and closer to the original. I'm liking it.

[mourner]

Dave, sorry for being such a perfectionist — it's better but still needs improvement. If you compare closely with the swipe control, you can notice that the original one is more round and natural in the upper part (look at the sides). Also, the white dot is a bit bigger.

[danzel]

Did another pass.
The roundness of the top is much closer now and the white circle should be the correct size too.

One major point that is different between the two is that in the current marker the image isn't actually centered, the circle part of the marker is about half a pixel to the right.
In my reproduction I've perfectly centered it, which makes it look a little different.

[mourner]

Hmm, looks pretty good now I think! A bit different, yes, but I guess no one will notice it. Will merge soon.

[danzel]

woop woop!

[mourner]

One last point: perhaps you could widen the top part just a little big more so that it could look more round? I mean, now the right edge looks more like original left edge due to centering, but could both edges made to look like the original right edge?

Also, try smushing the final images with http://www.smushit.com/ysmush.it/ — it can optimize the size quite a lot.

[danzel]

smushed, discussed shape on chat, it is fine :)

[mourner]

OK I'm ready to merge this, it's just one last grip I have that would be awesome to fix. I think now I know what I didn't like about the current shape:

Because of the full symmetry and the way antialiasing works, there are small artifacts on the outermost left and right sides of the image. They may not be immediately apparent, but when I look at a map with some markers on it, I can easily notice the difference due to small "spots" on the sides (the right one is more apparent), giving the new version an impression of being a bit rough. Maybe we'll have to make the source a bit asymmetrical to optimize for the small antialiased icon (which is more important than its retina counterpart).

[mourner]

Dave, please don't hate me for this 😢

[danzel]

Lol :p ill look at it next week.

[mourner]

Great! There are 8 issues left for 0.5 and I'd like to wrap up the release next week with this change in, so it's pretty high priority. :)

[danzel]

Did another pass, it is now width grid-fit so it looks better.

[mourner]

The marker got a bit fatter but I think I like it. :) Screw it, lets merge!

[danzel]