Fixes Issue 1204: Adds the border width to the viewport offset calculation #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| //add borders | ||
| top += parseInt(L.DomUtil.getStyle(el, "borderTopWidth"), 10) || 0; | ||
| left += parseInt(L.DomUtil.getStyle(el, "borderLeftWidth"), 10) || 0; |
There was a problem hiding this comment.
Yes, sorry. Please see commit cf883a0
|
Yeah, great catch — and quite surprising that no one noticed this until now. Probably because must users use 1px border so it's not very noticeable. :) Merging and hope it won't affect performance too much. |
mourner
added a commit
that referenced
this pull request
Dec 10, 2012
Fixes Issue 1204: Adds the border width to the viewport offset calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix leaflet creates accurate mouse events when the map-div has css borders.