handle existing query strings for WMS urls , #973 #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,14 +77,20 @@ L.Util = { | |||
| return obj.options; | |||
| }, | |||
|
|
|||
| getParamString: function (obj) { | |||
| getParamString: function (obj, existing_url) { | |||
There was a problem hiding this comment.
Please conform to existing code conventions (camelCase variables, whitespace, etc.)
|
Sorry about that - how does it look now, with 8d442b1 in? |
| var params = []; | ||
| for (var i in obj) { | ||
| if (obj.hasOwnProperty(i)) { | ||
| params.push(i + '=' + obj[i]); | ||
| } | ||
| } | ||
| return '?' + params.join('&'); | ||
| return (existingUrl.indexOf('?') === -1 ? '?' : '&') + params.join('&'); |
There was a problem hiding this comment.
I'd also add a check for existingUrl here so that it's not required (and it uses '?' if not provided). Otherwise looks good!
|
Okay, in. |
mourner
added a commit
that referenced
this pull request
Dec 27, 2012
handle existing query strings for WMS urls , #973
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use WMS layers currently, but this looks like a feature worth having. Issue #973
Including a test as well.