Layer control events for overlays #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rename the events to |
|
updated them |
mourner
added a commit
that referenced
this pull request
Jan 18, 2013
Layer control events for overlays
|
Thanks! |
|
overlayremove is also getting triggered when the baselayer is changed. Is this a bug? Also, it might be nice if the same obj was returned from baselayerchange, overlayadd, overlayremove so that they could be "processed" in a similar way. For example, overlayadd and overlayremove return the layer name, which is useful. But I don't see anything obvious in the obj returned from baselayerchange to target the layer that fired the event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would be helpful if layer control changes emitted events for overlays in addition to base ones.