Wrong default icon path on old IE in certain cases. #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2013 12:41
| @@ -44,7 +44,11 @@ L.Icon.Default.imagePath = (function () { | |||
| matches = src.match(leafletRe); | |||
|
|
|||
| if (matches) { | |||
| return src.split(leafletRe)[0] + '/images'; | |||
| if (src.split(leafletRe)[0]) { | |||
| return src.split(leafletRe)[0] + '/images'; | |||
There was a problem hiding this comment.
extract the split result into a variable path (so that there's no repetition) and use the ternary operator:
return (path ? path + '/' : '') + 'images';
|
here you go |
|
Much better isn't it? :) Thanks! |
mourner
added a commit
that referenced
this pull request
Jan 18, 2013
Wrong default icon path on old IE in certain cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE 7(and presumably IE 6) if leaflet.js is in the same directory as the page that is calling it, then the location of the image folder will be resolved as "undefined/images" instead of the full path + "/images" This seems to stem from IE 7 returning the relative urls unchanged instead of converting them to absolute ones like newer browsers.