Handle arrays of feature collections, #1298 #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (features[i].geometries || features[i].geometry) { | ||
| if (features[i].type === 'FeatureCollection') { | ||
| this.addData(features[i].features); | ||
| } else if (features[i].geometries || features[i].geometry) { |
There was a problem hiding this comment.
It would be simpler to just add a features[i].features check in this condition.
added 5 commits
January 20, 2013 19:35
| if (features[i].geometries || features[i].geometry) { | ||
| if (features[i].features) { | ||
| this.addData(features[i].features); | ||
| } else if (features[i].geometries || features[i].geometry) { |
There was a problem hiding this comment.
I meant that objects with features property are still handled well (see the first line of the method), so you don't need else if here, just everything in one condition.
|
Ah, the oneliner is what I had set up originally, then overanalyzed and decided to change it. In now. |
|
Looks good, thanks! |
mourner
added a commit
that referenced
this pull request
Jan 21, 2013
Handle arrays of feature collections, #1298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for arrays of FeatureCollections, which previously would be bypassed.
I tested it with the feature-group-bounds test and a modified geojson-sample.js.
This references issue #1298.