Popup fit after resize #1308
Closed
Popup fit after resize #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resize is detected. (incidentally, this also makes it impossible to pan a popup out of the view, maybe a resize should simply emit a 'vewreset' and avoid listening of 'moveend')
|
@lapo-luchini thanks for a very nice pull and sorry for a late response! I've put your changes with some modifications manually, making this behavior enabled with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a change to let the popup keep in view even after an image resize, my usecase is using a map full-screen on Android and a popup containing a FORM: when I press any text input the (sometimes huge) keyboard pops up and the screen real estate is 40% the size it was before and the popup is generally hidden by it. With this patch the popup keeps on screen (using the same logic it currently already does on appearing, only done also on resize).
I'm not sure this is a feature you'd want in general, but it was essential to me and, just in case, I'm opening this request to ease the import.
The second and third commit are because the solution used in the first lead to "bouncing" when the popup doesn't fit on screen.