add testacular runner for jasmine tests #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of git://github.com/Leaflet/Leaflet: Escape URI component in getParamString update build and changelog hasLayer not checking for null Return false when checking for a null object in L.Map.hasLayer, in response to issue Leaflet#1282. Fix js typo Add hasLayer to LayerGroup Add the method hasLayer to LayerGroup, return false when not present or checking for a null layer. condition on one line Revert "whitespace fix?" whitespace fix? whitespace again Trying to fix whitespace Simplify features check Handle arrays of feature collections
|
|
||
| var libSources = []; | ||
| for(var dep in deps){ | ||
| libSources = libSources.concat(deps[dep].src); |
There was a problem hiding this comment.
It's better to get the list with getFiles method in build.js for consistency (it just needs to be exported). It filters out duplicates, etc.
There was a problem hiding this comment.
ok, no problem I will export it!
|
yeeee! |
mourner
added a commit
that referenced
this pull request
Jan 31, 2013
add testacular runner for jasmine tests
|
Yay :) |
edjafarov
added a commit
to edjafarov/Leaflet
that referenced
this pull request
Jan 31, 2013
mourner
added a commit
that referenced
this pull request
Jan 31, 2013
my #1326 pull broke debug html pages. Pls merge the fix that adds deps script to all of those.
edjafarov
added a commit
to edjafarov/Leaflet
that referenced
this pull request
Feb 1, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step for improving tests and test coverage start running tests through testacular.