test coverage for Leaflet #1340

edjafarov · 2013-02-02T07:51:27Z

to use test coverage you need to:
$ cd node_modules
$ git clone git://github.com/testacular/testacular.git
$ cd testacular
$ sudo npm install
$ grunt
$ cd ../..
$ jake test --cov

mourner · 2013-02-02T10:56:06Z

Build failed, because SpecHelper needs to be run before other specs.

edjafarov · 2013-02-02T11:34:17Z

Thanks for tip. Will fix it asap!

On 02.02.2013, at 12:56, Vladimir Agafonkin notifications@github.com
wrote:

Build failed, because SpecHelper needs to be run before other specs.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1340#issuecomment-13027782.

edjafarov · 2013-02-02T13:32:44Z

not sure why build doesn't show status but it should work

mourner · 2013-02-02T18:45:31Z

I think it's because it can't be automatically merged (there are conflicts). Thanks!

edjafarov · 2013-02-02T18:49:11Z

will you resolve those? Or should I?

mourner · 2013-02-02T18:51:53Z

I'll merge manually on Monday.

edjafarov · 2013-02-02T18:54:45Z

👍

edjafarov · 2013-02-03T10:28:46Z

--------------------------------- File --------------------------------- src/ Leaflet.js src/control/ Control.Attribution.js Control.Layers.js Control.Scale.js Control.Zoom.js Control.js src/core/ Browser.js Class.js Events.js Handler.js Util.js src/dom/ DomEvent.DoubleTap.js DomEvent.MsTouch.js DomEvent.js DomUtil.js Draggable.js PosAnimation.Timer.js PosAnimation.js src/geo/ LatLng.js LatLngBounds.js src/geo/crs/ CRS.EPSG3395.js CRS.EPSG3857.js CRS.EPSG4326.js CRS.Simple.js CRS.js src/geo/projection/ Projection.LonLat.js Projection.Mercator.js Projection.SphericalMercator.js | Projection.js src/geometry/ Bounds.js LineUtil.js Point.js PolyUtil.js Transformation.js src/layer/ FeatureGroup.js GeoJSON.js ImageOverlay.js LayerGroup.js Popup.js src/layer/marker/ DivIcon.js Icon.Default.js Icon.js Marker.Drag.js Marker.Popup.js Marker.js src/layer/tile/ TileLayer.Canvas.js TileLayer.WMS.js TileLayer.js src/layer/vector/ Circle.js CircleMarker.js MultiPoly.js Path.Popup.js Path.SVG.js Path.VML.js Path.js Polygon.js Polyline.Edit.js Polyline.js Rectangle.js src/layer/vector/canvas/ Circle.Canvas.js Path.Canvas.js Polygon.Canvas.js Polyline.Canvas.js src/map/ Map.js src/map/anim/ Map.PanAnimation.js Map.ZoomAnimation.js src/map/ext/ Map.Control.js Map.Geolocation.js Map.Popup.js src/map/handler/ Map.BoxZoom.js Map.DoubleClickZoom.js Map.Drag.js Map.Keyboard.js Map.ScrollWheelZoom.js Map.TouchZoom.js --------------------------------- All files --------------------------------- -----+-----------+-----------+-----------+-----------+
| % Stmts |% Branches | % Funcs | % Lines |
-----+-----------+-----------+-----------+-----------+
| 90 | 50 | 100 | 90 |
| 90 | 50 | 100 | 90 |
| 64 | 44.92 | 50.98 | 64.37 |
| 56.52 | 36.36 | 63.64 | 58.14 |
| 78.18 | 77.08 | 62.5 | 78.18 |
| 31.58 | 10 | 20 | 31.58 |
| 80.65 | 30 | 50 | 80.65 |
| 44 | 25 | 50 | 44 |
| 77.88 | 68.82 | 75.61 | 78.54 |
| 43.75 | 62.16 | 100 | 43.75 |
| 100 | 87.5 | 88.89 | 100 |
| 89.23 | 74.24 | 100 | 89.23 |
| 54.55 | 25 | 75 | 66.67 |
| 64.79 | 58.97 | 63.64 | 64.79 |
| 22.83 | 22.6 | 31.25 | 23.33 |
| 23.91 | 12.5 | 25 | 23.91 |
| 1.49 | 0 | 0 | 1.52 |
| 50.59 | 44.74 | 50 | 51.85 |
| 38.46 | 31.18 | 64.71 | 39.08 |
| 8.89 | 6.33 | 18.18 | 9.52 |
| 3.45 | 10 | 0 | 3.57 |
| 3.33 | 0 | 0 | 3.57 |
| 51.81 | 46.03 | 45 | 52.5 |
| 67.74 | 75 | 66.67 | 70 |
| 42.31 | 32.56 | 35.71 | 42 |
| 76.47 | 100 | 57.14 | 76.47 |
| 100 | 100 | 100 | 100 |
| 50 | 100 | 0 | 50 |
| 100 | 100 | 100 | 100 |
| 50 | 100 | 0 | 50 |
| 85.71 | 100 | 75 | 85.71 |
| 40.91 | 0 | 33.33 | 40.91 |
| 33.33 | 100 | 0 | 33.33 |
| 8.33 | 0 | 0 | 8.33 |
100 | 100 | 100 | 100 |
| 100 | 100 | 100 | 100 |
| 62.76 | 49.02 | 70.45 | 62.56 |
| 86.49 | 76.67 | 80 | 86.11 |
| 56.79 | 36 | 54.55 | 56.79 |
| 71.43 | 58.33 | 72.22 | 71.43 |
| 8.7 | 0 | 0 | 8.7 |
| 100 | 50 | 100 | 100 |
| 4.12 | 0 | 0 | 4.21 |
| 7.14 | 0 | 0 | 7.14 |
| 4.76 | 0 | 0 | 4.84 |
| 4.55 | 0 | 0 | 4.55 |
| 4.88 | 0 | 0 | 5 |
| 2.61 | 0 | 0 | 2.7 |
| 50.72 | 28.23 | 42.55 | 51.47 |
| 18.18 | 0 | 0 | 18.18 |
| 73.68 | 41.67 | 100 | 73.68 |
| 72.97 | 45.45 | 75 | 72.97 |
| 13.33 | 0 | 14.29 | 13.33 |
| 4.55 | 0 | 0 | 4.55 |
| 57.28 | 31.25 | 50 | 59 |
| 43.15 | 32.81 | 43.4 | 43.51 |
| 9.52 | 0 | 0 | 9.52 |
| 8.7 | 0 | 0 | 8.7 |
| 50.76 | 36.84 | 58.97 | 51.28 |
| 32.37 | 20.83 | 31.78 | 32.85 |
| 32.26 | 0 | 41.67 | 32.26 |
| 20 | 100 | 0 | 20 |
| 35 | 0 | 28.57 | 35 |
| 4.55 | 0 | 0 | 4.55 |
| 61.63 | 37.04 | 56.25 | 63.1 |
| 4.84 | 14.71 | 0 | 4.92 |
| 57.58 | 33.33 | 50 | 57.58 |
| 6.67 | 0 | 0 | 7.14 |
| 9.09 | 10 | 15 | 9.17 |
| 64.86 | 45.83 | 68.75 | 65.75 |
| 28.57 | 100 | 0 | 28.57 |
| 6.36 | 13.24 | 5.26 | 6.48 |
| 16.67 | 25 | 0 | 16.67 |
| 5.06 | 13.04 | 6.67 | 5.19 |
| 8.33 | 12.5 | 0 | 8.33 |
| 7.69 | 10 | 0 | 7.69 |
| 52.43 | 42.86 | 47.62 | 54.26 |
| 52.43 | 42.86 | 47.62 | 54.26 |
| 10.28 | 11.11 | 12.5 | 10.58 |
| 18.18 | 7.41 | 16.67 | 18.18 |
| 6.76 | 13.89 | 10 | 7.04 |
| 30.95 | 0 | 30 | 30.95 |
| 84.62 | 100 | 75 | 84.62 |
| 4.55 | 0 | 0 | 4.55 |
| 14.29 | 0 | 0 | 14.29 |
| 26.87 | 8.33 | 23.81 | 27.84 |
| 22.58 | 0 | 33.33 | 24.14 |
| 66.67 | 100 | 33.33 | 66.67 |
| 20.93 | 12 | 10 | 20.93 |
| 54.35 | 10 | 36.36 | 54.35 |
| 17.86 | 0 | 20 | 18.52 |
| 8.51 | 8.33 | 14.29 | 9.3 |
-----+-----------+-----------+-----------+-----------+
| 38.49 | 30.35 | 37.83 | 39.12 |
-----+-----------+-----------+-----------+-----------+

danzel · 2013-02-03T20:39:06Z

I had to install grunt with:

npm install -g grunt
npm install -g grunt-cli

To get grunt to run.

mourner · 2013-02-03T22:07:30Z

@danzel thanks! Grunt wont be needed once the master testacular version gets to stable though.

edjafarov · 2013-02-04T08:45:50Z

@danzel @mourner nice catch though. If you expect people to use code coverage it might make sense to put all the details. Since as I know testacular releases are not regular and seems like they are in the middle of refactoring(*I have a pull req there and this weekend I was asked to refactor it in plugin:)), so sable release could happen tommorow or in 6 month :(

danzel · 2013-02-04T09:08:03Z

One issue I had with testacular is that after I reconfigured it for continuous mode, it would run initially and rerun when I saved. But the reruns would only rerun the failing tests, so if I made one of the tests that was passing fail it wouldn't be picked up.
@edjafarov Any idea if I've misconfigured it or if there is an option to have it re-run all the tests on save?

mourner · 2013-02-04T11:44:03Z

Merged, nice work Eldar! Had to manually fix whitespace though (2-space -> tabs).

danzel · 2013-02-18T23:00:41Z

To get PhantomJS going on windows, download it from http://phantomjs.org/download.html
And extract to: C:\Windows\Program Files\PhantomJS
So you have: C:\Windows\Program Files\PhantomJS\phantomjs.exe

I'll write these up in contributing.md

edjafarov added 2 commits February 2, 2013 05:29

test coverage initial commit

2da36a2

use master testacular only if --cov

071bb58

Fix: SpecHelper should be first

e4492b6

mourner added a commit that referenced this pull request Feb 4, 2013

merge #1340, fix whitespace

86cfce1

mourner merged commit e4492b6 into Leaflet:master Feb 4, 2013

mourner mentioned this pull request Feb 4, 2013

Improve Leaflet test coverage #1347

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test coverage for Leaflet #1340

test coverage for Leaflet #1340

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 3, 2013

Uh oh!

danzel commented Feb 3, 2013

Uh oh!

mourner commented Feb 3, 2013

Uh oh!

edjafarov commented Feb 4, 2013

Uh oh!

danzel commented Feb 4, 2013

Uh oh!

mourner commented Feb 4, 2013

Uh oh!

danzel commented Feb 18, 2013

Uh oh!

Uh oh!

Uh oh!

test coverage for Leaflet #1340

test coverage for Leaflet #1340

Uh oh!

Conversation

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

mourner commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 2, 2013

Uh oh!

edjafarov commented Feb 3, 2013

Uh oh!

danzel commented Feb 3, 2013

Uh oh!

mourner commented Feb 3, 2013

Uh oh!

edjafarov commented Feb 4, 2013

Uh oh!

danzel commented Feb 4, 2013

Uh oh!

mourner commented Feb 4, 2013

Uh oh!

danzel commented Feb 18, 2013

Uh oh!

Uh oh!