Change _propagateEvent to be careful that it doesn't overwrite e.layer #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if it is already set. Allows markers to be in multiple FeatureGroups and have the events come through correctly. See the test for details. Fixes Leaflet.markercluster#128 ( Leaflet/Leaflet.markercluster#128 )
|
Agree with the new behavior, merging — thanks Dave! |
mourner
added a commit
that referenced
this pull request
Feb 8, 2013
Change _propagateEvent to be careful that it doesn't overwrite e.layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if it is already set. Allows markers to be in multiple FeatureGroups and have the events come through correctly. See the test for details.
Fixes Leaflet/Leaflet.markercluster#128
The old behaviour was broken in this case (e.layer would become a FeatureGroup). I can't think of any case the new behaviour would be undesirable, but maybe you can mourner?
Thanks :)