Allow previously created popups to be used with bindPopup #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
mourner
added a commit
that referenced
this pull request
Feb 15, 2013
Allow previously created popups to be used with bindPopup
|
@snkashis we probably need to revise |
|
Will take care of it today. On Feb 17, 2013, at 9:37, Vladimir Agafonkin notifications@github.com wrote:
|
|
Thanks. :) There's no rush though. BTW, I think I'll eventually extract all popup code shared between different layers into one module so there's no duplication. But that will be done as a part of a bigger refactoring so I'll have to do it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up bindPopup to use an existing popup if provided instead of creating a new one.
I could see how this could be quite useful for certain scenarios.
References issue #1208