dblclicking now zooms around mouse, not centre #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I didn't realize that it's now expected behavior for dblclick zoom... Several years ago it wasn't for sure. :) And many online maps behave the old way... Although I see now that e.g. Google Maps has the new behavior. And I generally agree it's better for usability. Regarding I'll merge the pull manually, creating the method along the way. |
|
Cool, looked but didn't see #1157 "it is expected" might have been a bit strong. Its a personal preference since its easier to zoom in multiple times. ModestMaps does it this way as well. Bing doesn't though. |
|
Mouse wheel zoom has the desired behaviour already, not sure if we can share some code there? |
mourner
added a commit
that referenced
this pull request
Apr 11, 2013
|
@danzel yep, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like with scrollzooming, it is expected that that the map will zoom around the clicked point, not the center.
Maybe this should be added as map.setZoomAbout(zoom, point) or something, since the functionality is shared with the scroll handler, but wasn't sure if it was preferrable.