Events#clearAllListeners #1599
Merged
Events#clearAllListeners #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (type.substr(-4) === '_idx') { clearObject(events[type], type); } | ||
| } | ||
| } | ||
| return this; |
There was a problem hiding this comment.
Hmm, why not just do delete this[key] instead of all the code?
There was a problem hiding this comment.
well, because obviously that would be way too easy. :D
|
Looks good :) I only wonder if the naming inconsistency is OK (all methods have |
|
That's where I started, but thought it wasn't quite explicit enough - maybe split the difference with |
|
Renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Events#clearAllListeners, a convenience method to deregister all of an object's event bindings. It can be called directly or by calling off() with no arguments. Fixes #1502.