Fix regexes that break Leaflet inside a multi line comment block, fixes #1288 #1607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1288.
Currently the
*/characters inside Leaflet's regular expressions break multi line comment blocks that can be used for lazy evaluating javascript [source 1] [source 2].In addition to working around the regular expressions, I have also added
L.Util.trimwhich with these changes is used byL.Util.splitWordsandL.DomUtil.removeClass. If addingtrimmethod is a problem, I can provide an alternative workaround.trimandremoveClassmethods are the same ones used in Pikaday.js:https://github.com/dbushell/Pikaday/blob/master/pikaday.js#L73
List of changes:
L.Util.trimmethod.L.Util.splitWordsto callL.Util.trim.L.DomUtil.removeClasswith a new one to avoid having a regular expression with*/. Also usesL.Util.trim.Path.VML.jsto avoid having a regular expression with*/.Linting and tests:
Let me know if any changes are needed.