Issue #1631: Fixed a bug on removeEventListener #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.
| it('can handle calls to #removeEventListener on objects with no registered event listeners', function () { | ||
| var obj = new Klass(); | ||
| obj.removeEventListener('test'); | ||
| }); |
There was a problem hiding this comment.
No assertions here, so this test currently doesn't do anything... Add expect(...).not.to.throw or something like this.
|
You also have a failed build (due to whitespace error). Please run |
|
Yeah I noticed. I adressed both issues in second commit. |
mourner
added a commit
that referenced
this pull request
Apr 29, 2013
Issue #1631: Fixed a bug on removeEventListener
|
Looks good, thanks! |
|
You're welcome. Keep up the great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for issue #1631 where removeEventListener would throw when no event listeners are registered on the object.