Allow value of 0 in L.DivIcon's html parameter #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
mourner
added a commit
that referenced
this pull request
Apr 29, 2013
Allow value of 0 in L.DivIcon's html parameter
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement pull request for #1627.
Not sure how to verify that it will pass in Travis, but the "whitespace after :" issue is fixed. Sorry about the bad pull request before.
This pull request allows
new L.DivIcon({className:'numbericon',html:0});
to create an icon with a '0' in the label.
Icons created with an html value of 0 ended up with an empty string for html instead of a 0 since options.html evaluated to false.
This sets a default value of false, and checks if options.html !== false.