hasLayer and removeLayer by id. #1642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, thanks! |
mourner
added a commit
that referenced
this pull request
May 3, 2013
hasLayer and removeLayer by id.
mourner
added a commit
that referenced
this pull request
May 4, 2013
Extend #1642 to include FeatureGroups and lookup by id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can override Layer stamping with 786fadd I think it makes sense to access them with their id.
In my use case I'm using custom indexes (Backbone.Model.cid) to identify polygons, and this would be a convenient way to keep things in sync. For example, if a model is deleted I can remove the polygon from the map with
removeLayer(model.cid).If not, I can still use
LayerGroup._layers[model.cid]