Skip to content

Conversation

lubberscorrado
Copy link

No description provided.

@mourner
Copy link
Member

mourner commented May 3, 2013

I think that for the sake of simplicity it doesn't make much sense to include translations in Leaflet when we only have a couple of simple strings to translate — it's better to just put the text into options and leave it up to developers.

@mourner mourner closed this May 3, 2013
@lubberscorrado
Copy link
Author

well, we implemented leaflet into an application which is multilanguage and without that change i would need to create and maintain several full leaflet.js versions just for that hardcoded textfiles. So its much more maintain-friendly to hold those strings in separete object-attributes so i can still get the lates leaflet.js without any change and my separte local-files are always working.

@mourner
Copy link
Member

mourner commented May 3, 2013

I suggest submitting a simpler PR that makes the text configurable through control options. Then you wouldn't need to maintain a separate Leaflet version since the text will be specified in your application code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants