Make sure events don't fire after listener is removed. #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a problem with a dangling event listener, which is called even after it has been removed. This situation can occur when a listener is removed during an even dispatch. To fix this problem, the old action is replaced with a NOOP, so that when the listener is being fired, it is not the old listener but the NOOP.
| obj.fireEvent('test'); | ||
| expect(spy.called).to.be(false); | ||
| }); | ||
|
|
There was a problem hiding this comment.
There's a minor whitespace problem here (mixed tabs and spaces), otherwise looks good!
mourner
added a commit
that referenced
this pull request
May 8, 2013
Make sure events don't fire after listener is removed.
mourner
added a commit
that referenced
this pull request
May 8, 2013
|
Sorry confusion and thanks a lot for the fix, Raimund! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a problem with a dangling event listener, which is
called even after it has been removed. This situation can occur when a
listener is removed during an even dispatch.
To fix this problem, the old action is replaced with a NOOP, so that
when the listener is being fired, it is not the old listener but the
NOOP.