Skip to content

Conversation

scooterw
Copy link

An attempt at resolving issue #1670. See also: mapbox/mapbox.js#383

@mourner
Copy link
Member

mourner commented May 16, 2013

Thanks! Please fix the whitespace (spaces to tabs).

@scooterw
Copy link
Author

Converted spaces to tabs. Let me know if there are other issues and I will fix. Thanks!

@mourner
Copy link
Member

mourner commented May 16, 2013

Sorry to annoy with such a minor thing but I meant only fixing whitespace for the lines that you've added. Leaflet uses "smart tabs" approach — tabs for indentation and spaces for alignment (e.g. under a var statement).

Regarding the change itself, can you check all the major browsers to see if there's no regressions from this change?

@scooterw
Copy link
Author

No annoyance. I apologize. I should have paid closer attention. Let me work on fixing the tab / spacing issues. I will also check for regressions in major browsers.

@scooterw
Copy link
Author

Ran test suite in IE 7 / 8 / 9, FF, Chrome, and Safari. No regressions that I could see from master. Failing tests in latest Chrome and Safari (popup closing) were present in master as well as feature branch.

@mourner
Copy link
Member

mourner commented May 17, 2013

@jfirebaugh ok to merge?

@jfirebaugh
Copy link
Member

Tested it against the original page I saw this issue on and it looks good. 👍 Thanks @scooterw for fixing!

jfirebaugh added a commit that referenced this pull request May 17, 2013
calculate x position with postion:relative and width/maxWidth
@jfirebaugh jfirebaugh merged commit 72ac52c into Leaflet:master May 17, 2013
scooterw pushed a commit to scooterw/Leaflet that referenced this pull request Jul 4, 2013
mourner added a commit that referenced this pull request Jul 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants