Fix SetIcon with DivIcons #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues remain (Can't change a marker with a DivIcon to have an image Icon or vice versa)
|
Thanks Dave, very nice fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #1726 you cannot use setIcon and pass a new DivIcon. If you do the icon doesn't end up getting updated.
This breaks MarkerCluster which relies heavily on DivIcon.
Also probably breaks leaflet.awesome-markers and some others.
Now we check that the Icon has actual reused the dom element, if it hasn't we do the old behaviour of removing the dom element and adding the new one.
Also made DivIcon reuse the div.
Fixes #1753 and Fixes Leaflet/Leaflet.markercluster#190