Avoid using preventDefault on mousedown #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as the mousedown event does not have preventDefault, dragging out of an iframe works as expected.
| if (e.type === 'mousedown') { | ||
| L.DomEvent.on(document, 'mouseout', this._onUp, this); | ||
| } | ||
| this._userSelect = L.DomEvent._suppressUserSelect(); |
There was a problem hiding this comment.
any reason to save a handle here instead of keeping it as a global private property in DomEvent?
|
There were existing methods for that already, just perhaps not as complete: https://github.com/Leaflet/Leaflet/blob/master/src/dom/DomUtil.js#L120-L135 |
|
Fixed in 60476da. |
|
Needs some more browser testing and we're good to go. |
|
Decided to merge this already because it fit really well into #1783. I think there will be not much problems with it but lets check on IE at least before release. |
mourner
added a commit
that referenced
this pull request
Jun 25, 2013
|
@jfirebaugh unfortunately had to add peventDefault back as this change completely broke dragging in Firefox. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in d3/d3#1289 and d3/d3#1322, this produces better drag behavior in iframes. I borrowed the method for supressing text selection from there as well.