Stop transition if element is outside fo the DOM

[boujeepossum]

I have a backbone application, where map is rendered once and then stored globally. And sometimes when users open another page before animation is complete, it gives me a bunch of errors.

Uncaught TypeError: Cannot read property '1' of null leaflet.js:8210
L.PosAnimation.L.Class.extend._getPos leaflet.js:8210
L.PosAnimation.L.Class.extend._onStep leaflet.js:8193
(anonymous function)

on that line.

_getPos: function () {
        var left, top, matches,
            el = this._el,
            style = window.getComputedStyle(el);

        if (L.Browser.any3d) {
            matches = style[L.DomUtil.TRANSFORM].match(this._transformRe);
            left = parseFloat(matches[1]);
--------------   Uncaught TypeError: Cannot read property '1' of null
            top  = parseFloat(matches[2]);
        } else {
            left = parseFloat(style.left);
            top  = parseFloat(style.top);
        }

        return new L.Point(left, top, true);
    },

[mourner]

It was fixed recently but in a slightly different way. https://github.com/Leaflet/Leaflet/blob/master/src/dom/PosAnimation.js#L61-L62
Thanks for the pull though!

[boujeepossum]

but will it stop transition in this case? because what i had is infinite setInterval which only cleared when i go back to the map page

[mourner]

@rutkovsky if it's the case, then you're right! I didn't want to merge this fix because step listener is performance-sensitive since it happens often el.contains may be slow... Perhaps lets make a similar fix but with a different condition — checking for existance of matches when parsing transform.

[boujeepossum]

@mourner will that work? #1856