Skip to content

Conversation

fastrde
Copy link
Contributor

@fastrde fastrde commented Aug 8, 2013

when you shift click on the map directly after dragging no click event get fired. (boxZoom: false)

to construct the bug:

  1. click on map => clickEvent fired
  2. shift click on map => clickEvent fired
  3. drag map around
  4. shift click on map => no click Event
  5. click on map => clickEvent fired
  6. shift click on map => clickEvent fired

the buggy workflow:

  • at 3 L.Draggable this._moved is set to true.
  • at 4 L.Draggable line 49 _onDown returns directly because shift is pressed. and this._moved is not set back to false in line 67. So this._moved is still true.
  • at 4 L.Map line 679 returns because this.dragging.moved() returns true. And no event get fired.

lg

fastrde

@fastrde
Copy link
Contributor Author

fastrde commented Aug 8, 2013

oh it's not so trivial as i think... Now it get fires every time the map has moved..

@fastrde fastrde closed this Aug 8, 2013
@mourner
Copy link
Member

mourner commented Aug 8, 2013

Thanks for the attempt though! Keep me updated :)

mourner added a commit that referenced this pull request Aug 8, 2013
fixes shift clicking Issue described in (Issue #1950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants