Wrong transformation in CRS EPSG3395 #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Alex! I'm still so confused about all those projections... :( |
mourner
added a commit
that referenced
this pull request
Sep 10, 2013
Wrong transformation in CRS EPSG3395
|
Special thanks for more tests, much needed additions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is still bug in EPSG3395 (after #1578, #1796 and wrong #358).
The problem is in transformation from linear projection coordinates to pixels. Current transformation sets different scales for X and Y coordinates, but it should be the same (major Earth radius). As a result, EPSG3395 raster tiles with EPSG3395 map projection are shifted (for example, relative to vector data).
I've added some tests for CRS classes, that check projections of edge pixels of zero zoom tile.