Support Pointer events as well as MsPointer Events #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, took a lot of changes but that looks good to me! Thanks for the great work Dave, it seems we're saved now. :) |
|
Thanks :) |
|
@danzel so, did you encounter any problems with this? |
|
Will do it now, busy week :) |
|
build fixed :) |
|
Is it tested on IE11 touch? |
ghost
assigned
|
I don't have IE11 touch yet to test on |
|
Ah what the hell, lets merge and hope someone tests, in the worst case nothing changes as the current version doesn't work on IE11 touch. :) |
mourner
added a commit
that referenced
this pull request
Oct 10, 2013
Support Pointer events as well as MsPointer Events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2037
I've taken a slightly different route to @DanielX2 in #2039. I did use your code for reference though, thank you very much :-)
Now the class is a generic Pointer -> Touch wrapper and it specifically listens to Ms prefixed ones if you are on IE10 where they exist (feature detected of course).
Please test, I've tested on IE10 touch and IE11 Desktop and it seems good.
Check this diff for the actual changes:
danzel@bf3b660
Renaming messes up the diff viewer.