Remove hardcoded world size from L.TileLayer #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 23, 2013 09:58
| _getWrapTileNum: function () { | ||
| // TODO refactor, limit is not valid for non-standard projections | ||
| return Math.pow(2, this._getZoomForUrl()); | ||
| _getWrapTileNum: function () { |
|
That's a really nice way to remove the hardcode! I'll merge this for 0.7. |
mourner
added a commit
that referenced
this pull request
Nov 6, 2013
Remove hardcoded world size from L.TileLayer
mourner
added a commit
that referenced
this pull request
Nov 6, 2013
|
Patched up |
|
Yes, sorry! |
|
No problem, thanks a lot for the pull :) Feel free to check out other projection-related hardcodes in Leaflet codebase or any ways to improve the projections code and send suggestions/pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the parts hardcoded for spherical Mercator from L.TileLayer into L.CRS, where they can be overridden more easily.
In particular, this makes it possible to use TMS with L.TileLayer with projections other than spherical Mercator, which isn't possible today. (Proj4Leaflet currently has a pretty nasty workaround for this, which would be nice to get rid off.)
To do this, the method
getSizeis added to ICRS, which returns the size of the entire CRS in pixels, for a given zoom level. This is in turn used in L.TileLayer to calculate the the proper tile number for wrapping and TMS.