Reimplement max bounds enforcement with proper zooming and lookahead #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deltas are calculated on x, y pixel coordinates separately. Options are propagated from setMaxBounds to panBy. No panBy loops. Fixes #1908.
…bounds * 'patch-1' of https://github.com/kapouer/Leaflet: test Map#setMaxBounds and Map#panInsideBounds panInsideBounds: fit or center, pass options, remove boundsMinZoom
mourner
added a commit
that referenced
this pull request
Nov 14, 2013
Reimplement max bounds enforcement with proper zooming and lookahead
|
Looks good. It behaves a little strange in IE7 if you do some inertial drags, but otherwise fine :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1946 by @kapouer. This changes the max bounds behavior so that minZoom is not enforced, and instead the view stays anchored to the bounds when zooming in/out. Should fix a hell lot of max bounds issues, including #1908, #2081, #2168.