Fast universal event propagation #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2013
|
Looks good. Thanks |
mourner
added a commit
that referenced
this pull request
Dec 18, 2013
Fast universal event propagation
|
Checked through this, seems awesome :) |
mourner
added a commit
that referenced
this pull request
Dec 19, 2013
mpwassell
pushed a commit
to IQGeo/Leaflet
that referenced
this pull request
Feb 20, 2015
mpwassell
pushed a commit
to IQGeo/Leaflet
that referenced
this pull request
Feb 23, 2015
…eaflet#2311" This reverts commit 0dd9c86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes adding layers to
FeatureGroupand propagating events 10x faster while making it universal (propagates any events, and we can easily add propagation to other classes if needed). All children likeGeoJSONandMarkerClusterGroupwill benefit from the speedup as well.This is my attempt at tackling #2196 and #1107. @danzel @luiscamachopt thoughts?