Add oldLatlng parameter to Marker move event #2412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to support moving markers.
mourner
added a commit
that referenced
this pull request
Jan 28, 2014
Add oldLatlng parameter to Marker move event
| this._latlng = L.latLng(latlng); | ||
| this.update(); | ||
| return this.fire('move', {latlng: this._latlng}); | ||
| return this.fire('move', { oldLatlng: oldLatlng, latlng: this._latlng }); |
There was a problem hiding this comment.
we now have a naming problem though... latlng is the only exception among properties that have camelCase, although changing it will break compatibility, and providing both is ugly, but now with oldLatlng it's nor camelCase nor lowercase, which is confusing... See #1423
There was a problem hiding this comment.
I've changed it to oldLatLng and pushed it up. We shouldn't make more problems :)
danzel
added a commit
that referenced
this pull request
Jan 28, 2014
|
Pushed the documentation for this to gh-pages-master, I think that's the right place |
danzel
added a commit
that referenced
this pull request
Jan 29, 2014
|
One possible issue: Marker drag doesn't pass through oldLatLng |
60 tasks
danzel
added a commit
that referenced
this pull request
Mar 6, 2015
danzel
added a commit
that referenced
this pull request
Jul 3, 2015
6 tasks
This was referenced Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow MarkerCluster to support moving markers.
Refs Leaflet/Leaflet.markercluster#57
Not sure about the capitalization. We have a 'latlng' parameter, so I matched that.