Fix for touch-sensitive browsers detecting drag on tap #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome 33 on Android seems to very commonly detect a 1 pixel drag movement during a standard touch tap. This fix prevents a drag from beginning until the X and Y drag offset is at least 3 pixels in total.
|
This fix affects issue #2502 |
|
Please fix the build. |
|
You can also submit a similar pull for the stable branch. |
|
Fixed. Not sure how to specify the branch, I thought I was on the stable branch. |
mourner
added a commit
that referenced
this pull request
Mar 1, 2014
Fix for touch-sensitive browsers detecting drag on tap
|
Thanks! You specify the target branch when you create the pull. |
This was referenced Apr 11, 2014
mourner
added a commit
that referenced
this pull request
Apr 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 33 on Android seems to very commonly detect a 1 pixel drag movement during a standard touch tap, when no drag was intended, making it extremely difficult to tap on markers. This fix prevents a drag from beginning until the X and Y drag offset is at least 3 pixels in total.