Add stop animation support #2563

Merged
merged 9 commits into from Mar 19, 2014

Conversation

Projects
None yet
2 participants
Owner

danzel commented Mar 19, 2014

fixes #2560

danzel added some commits Mar 19, 2014

@danzel danzel Add an element for tracking zoom animations. Use it for trying to sto…
…p a map zoom. Still doesn't quite work right. Stopping a zoomPan or PanAnimation does work however. Code is all cludgy :)

refs #2560
5c073a3
@danzel danzel Stop animating before starting a ZoomPan, otherwise they both run at …
…the same time.
bf8d67a

We should probably move all that stuff to some of the anim files or create a new "general" Map.Anim.js one.

Owner

danzel replied Mar 19, 2014

Agreed, just cludging it in while I figure everything out :)

lets have it as just stop()

Owner

danzel replied Mar 19, 2014

ok done

Do we need the Layer class here? Or we could simplify this and just create an HTML element and put it somewhere.

Owner

danzel replied Mar 19, 2014

It needs to listen to those 2 events and have the leaflet-zoom-animated class, but it probably doesn't need to be a layer. Will keep in mind to investigate.

yeah you can add the events and the class manually and this would get simpler

mourner merged commit ed6e86c into Leaflet:easey Mar 19, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment