New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inertia animation with worldCopyJump enabled #3038

Merged
merged 1 commit into from Nov 18, 2014

Conversation

Projects
None yet
3 participants
@flemenach

flemenach commented Nov 18, 2014

Hello,

This patch fixes an issue where inertia animation fails when dragging over 180/-180° with the 'worldCopyJump' option enabled

See #2624 for more details

Hope this commit will be useful

@mourner

This comment has been minimized.

Show comment
Hide comment
@mourner

mourner Nov 18, 2014

Member

Certainly a nice and welcome fix! I'm only thinking whether we can avoid cloning a point on every drag event...

Member

mourner commented Nov 18, 2014

Certainly a nice and welcome fix! I'm only thinking whether we can avoid cloning a point on every drag event...

mourner added a commit that referenced this pull request Nov 18, 2014

Merge pull request #3038 from flemenach/worldcopy-inertia
Fix inertia animation with worldCopyJump enabled

@mourner mourner merged commit 2bd788a into Leaflet:master Nov 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@danzel

This comment has been minimized.

Show comment
Hide comment
@danzel

danzel Nov 18, 2014

Member

if _absPos is already a point object we could just copy the details across from _newPos ?

Member

danzel commented Nov 18, 2014

if _absPos is already a point object we could just copy the details across from _newPos ?

@mourner

This comment has been minimized.

Show comment
Hide comment
@mourner
Member

mourner commented Nov 19, 2014

@danzel yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment