Empty popup on Internet Explorer #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Fabien |
|
Sorry for not reacting for so long, will be merged in a few days! |
|
mourner, this is resolved? |
|
Merged now, thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a DOM node as content results in an empty popup on IE (tested with IE 8), see:
http://jsfiddle.net/nrenner/ZdBtG/
This is because
innerHTML = ''in IE seems not only to remove child elements, but also to clean their content [1]. As _updateContent is called twice on openPopup, the content is already emptied when the popup is shown.[1] http://www.quirksmode.org/dom/w3c_html.html#t03