Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add the plugin tutorials from #4356 #4854

Merged
merged 2 commits into from Oct 7, 2016

Conversation

Projects
None yet
2 participants
@IvanSanchez
Copy link
Member

IvanSanchez commented Aug 27, 2016

Replaces #4356, fulfills part of #4239

@IvanSanchez IvanSanchez added this to the 1.1 milestone Sep 26, 2016

@IvanSanchez IvanSanchez force-pushed the plugin-tutorials branch from 3088d96 to 5fdc1fb Oct 4, 2016

@IvanSanchez

This comment has been minimized.

Copy link
Member Author

IvanSanchez commented Oct 4, 2016

I've rebased, after some conflicts popped up due to #4965. Should be fine for merging now. cc @mourner @yohanboniface @perliedman

@perliedman perliedman merged commit d40d82a into master Oct 7, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@perliedman perliedman removed the in progress label Oct 7, 2016

@perliedman

This comment has been minimized.

Copy link
Member

perliedman commented Oct 7, 2016

Really like the work you've put into these. Even as an experienced Leaflet user it gives some "huh, hadn't thought of it like that" moments. Great job!

I read through them, but of course I might still have missed some details - I think that's fine and we'll clean up the small things when we find them.

@IvanSanchez

This comment has been minimized.

Copy link
Member Author

IvanSanchez commented Oct 7, 2016

@perliedman Appreciated :-)

With a bit of luck, I'll be able to put more work on the "zoom tutorials" of #5007, while @mourner fights the ES6 dragon.

@IvanSanchez IvanSanchez deleted the plugin-tutorials branch Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.