docs: Fix path of Code Coverage report page on CONTRIBUTING.md file #5005

Merged
merged 1 commit into from Oct 11, 2016

Projects

None yet

3 participants

@serdarkacka
Contributor

Hello,

When I run

jake test --cov

command, the coverage folder is created on the Leaflet folder. Also on .gitignore file it is written as belonging to Leaflet folder, not to spec folder. However, on CONTRIBUTING.md the path of the report page is spec/coverage/<environment>/index.html. This pull request attempts to fix this documentation problem.

@mourner mourner added the needs review label Oct 6, 2016
@serdarkacka
Contributor

@IvanSanchez is there something wrong with this PR? This is my first time trying to contribute to an open-source project. If so, I can change or close the PR.

@IvanSanchez
Member

Yup, looks good. I don't remember when or why the coverage path changed.

@IvanSanchez IvanSanchez merged commit eff82bf into Leaflet:master Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@serdarkacka
Contributor

Thank you @IvanSanchez.

@serdarkacka serdarkacka deleted the serdarkacka:fix-path-about-code-coverage branch Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment